• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

rentpath / react-ui / 2352 / 1
56%
master: 87%

Build:
Build:
LAST BUILD BRANCH: csc/DX-156
DEFAULT BRANCH: master
Ran 23 Oct 2018 07:26PM UTC
Files 116
Run time 9s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

23 Oct 2018 07:19PM UTC coverage: 56.01% (+0.1%) from 55.883%
GITHUB_TOKEN=[secure]

Pull #415

travis-ci

web-flow
fix(photo): ssr missing img tag

affects: @rentpath/react-ui-core

Issue: We render the \`<img/>\` tag with SSR before. Bbut what happens is the DOM img is loaded in
concurrently while the client bundle is loaded in. So trying to use \`onError\` which react intercepts
ends up in a race condition where the img throws an error in the dom first potentially.
Fix:
Offload setting of src to the handler. Check for differences in src !== fallbackUrl and make
adjustments accordingly. State has to be fired if these 2 are the same so the mounted component will
update and force a re-render.
Pull Request #415: fix(photo): ssr missing img tag

581 of 1077 branches covered (53.95%)

Branch coverage included in aggregate %.

980 of 1710 relevant lines covered (57.31%)

10.84 hits per line

Source Files on job 2352.1 (GITHUB_TOKEN=[secure])
  • Tree
  • List 0
  • Changed 1
  • Source Changed 1
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 1611
  • Travis Job 2352.1
  • 49ab0630 on github
  • Prev Job for GITHUB_TOKEN=[secure] on tj/photo-ssr (#2348.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc