• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

rentpath / react-ui / 2352
56%
master: 87%

Build:
Build:
LAST BUILD BRANCH: csc/DX-156
DEFAULT BRANCH: master
Ran 23 Oct 2018 07:25PM UTC
Jobs 2
Files 116
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2352

Pull #415

travis-ci

web-flow
fix(photo): ssr missing img tag

affects: @rentpath/react-ui-core

Issue: We render the \`<img/>\` tag with SSR before. Bbut what happens is the DOM img is loaded in
concurrently while the client bundle is loaded in. So trying to use \`onError\` which react intercepts
ends up in a race condition where the img throws an error in the dom first potentially.
Fix:
Offload setting of src to the handler. Check for differences in src !== fallbackUrl and make
adjustments accordingly. State has to be fired if these 2 are the same so the mounted component will
update and force a re-render.
Pull Request #415: fix(photo): ssr missing img tag

581 of 1077 branches covered (53.95%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 1 file covered. (100.0%)

980 of 1710 relevant lines covered (57.31%)

21.68 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2352.1 (GITHUB_TOKEN=[secure]) 23 Oct 2018 07:26PM UTC 0
56.01
Travis Job 2352.1
2 2352.2 (GITHUB_TOKEN=[secure]) 23 Oct 2018 07:25PM UTC 0
56.01
Travis Job 2352.2
Source Files on build 2352
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2352
  • Pull Request #415
  • PR Base - master (#2348)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc