• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

CS2113-AY1819S1-W13-1 / main / 55 / 1
78%
master: 78%

Build:
DEFAULT BRANCH: master
Ran 04 Oct 2018 04:40PM UTC
Files 100
Run time 6s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

04 Oct 2018 04:35PM UTC coverage: 88.849%. Remained the same
55.1

Pull #18

travis-ci

web-flow
PersonListPanelTest#createXmlFileWithPersons(): Fix incorrect path

createXmlFileWithPersons() saves the location of the temporarily
generated .xml file to:

    src/test/data/sandboxmanyPersons.xml

instead of:

    src/test/data/sandbox/manyPersons.xml

It is likely that the original author of the test intended the saving
location to be the latter, given that it has always resolved to the
latter until we revamped the path handling logic in AddressBook to use
java.nio.file.Path API, which introduced this discrepancy (commit
9eac635d9).

Saving the temporary .xml file to the 'sandbox' folder is also ideal as
the folder is git-ignored, so even if JVM crashes and does not clean
up the temporary file, students would not accidentally commit this
potentially _enormous_ .xml file into the repository.

Let's fix the incorrect path.
Pull Request #18: Merge from upstream se-edu/AB4

1474 of 1659 relevant lines covered (88.85%)

0.89 hits per line

Source Files on job 55.1
  • Tree
  • List 0
  • Changed 8
  • Source Changed 8
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 28
  • Travis Job 55.1
  • 524e3c82 on github
  • Prev Job for on master (#54.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc