CS2113-AY1819S1-W13-1 / main / 55

78%

Pull #18

travis-ci

PersonListPanelTest#createXmlFileWithPersons(): Fix incorrect path

createXmlFileWithPersons() saves the location of the temporarily
generated .xml file to:

    src/test/data/sandboxmanyPersons.xml

instead of:

    src/test/data/sandbox/manyPersons.xml

It is likely that the original author of the test intended the saving
location to be the latter, given that it has always resolved to the
latter until we revamped the path handling logic in AddressBook to use
java.nio.file.Path API, which introduced this discrepancy (commit
9eac635d9).

Saving the temporary .xml file to the 'sandbox' folder is also ideal as
the folder is git-ignored, so even if JVM crashes and does not clean
up the temporary file, students would not accidentally commit this
potentially _enormous_ .xml file into the repository.

Let's fix the incorrect path.

20 of 20 new or added lines in 8 files covered. (100.0%)

1474 of 1659 relevant lines covered (88.85%)

0.89 hits per line