8
74%
develop: 74%

Ran 04 Oct 2018 10:57AM UTC

Files 389

Run time 16s

Badge

Embed ▾

Committed 04 Oct 2018 10:24AM UTC coverage: 53.719% (-0.02%) from 53.737%

Job # TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests"

Build Type

push

travis-ci

Committed by

sphuber

Commit Message

Fix process leaks due to `ProxyCommand` (#2019)

This commit addresses two issues:

  * The constructor of `_DetachedProxyCommand` should _not_ call `super`.
    The reason for this is that the detached version creates a _different_
    subprocess. If the `super` is also called, two subprocesses are created.
  * In the `close` method of `_DetachedProxyCommand`, the subprocess is
    killed more aggressively, and we `poll` the subprocess to avoid having
    defunct processes.

The subprocess killing is implemented as follows:

  * `.terminate()` the subprocess
  * `.poll()` for 2 seconds to see if it exits
  * if it hasn't, `.kill()`, and `.poll()` again for 2 seconds

This part is a bit hand-wavy, but I wanted to avoid using the `.wait()` method.
On balance I think it's better if the daemon just continues if the subprocess
is really unkillable.

Run Details

19246 of 35827 relevant lines covered (53.72%)

0.54 hits per line

aiidateam / aiida_core / 3919 / 8
74%
develop: 74%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3919.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")

aiidateam / aiida_core / 3919 / 8 74% develop: 74%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3919.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")

aiidateam / aiida_core / 3919 / 8
74%
develop: 74%

README BADGES
x