3919
74%

Ran 04 Oct 2018 10:39AM UTC

Jobs 4

Files 389

Run time 20min

Badge

Embed ▾

pending completion

Build # 3919

Build Type

push

travis-ci

Committed by

sphuber

Commit Message

Fix process leaks due to `ProxyCommand` (#2019)

This commit addresses two issues:

  * The constructor of `_DetachedProxyCommand` should _not_ call `super`.
    The reason for this is that the detached version creates a _different_
    subprocess. If the `super` is also called, two subprocesses are created.
  * In the `close` method of `_DetachedProxyCommand`, the subprocess is
    killed more aggressively, and we `poll` the subprocess to avoid having
    defunct processes.

The subprocess killing is implemented as follows:

  * `.terminate()` the subprocess
  * `.poll()` for 2 seconds to see if it exits
  * if it hasn't, `.kill()`, and `.poll()` again for 2 seconds

This part is a bit hand-wavy, but I wanted to avoid using the `.wait()` method.
On balance I think it's better if the daemon just continues if the subprocess
is really unkillable.

Run Details

24241 of 35827 relevant lines covered (67.66%)

2.27 hits per line

Jobs

ID	Job ID	Ran	Coverage
5	3919.5 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")	04 Oct 2018 10:39AM UTC	59.92	Travis Job 3919.5
6	3919.6 (TEST_AIIDA_BACKEND=django TEST_TYPE="tests")	04 Oct 2018 10:58AM UTC	54.81	Travis Job 3919.6
7	3919.7 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")	04 Oct 2018 10:59AM UTC	58.83	Travis Job 3919.7
8	3919.8 (TEST_AIIDA_BACKEND=sqlalchemy TEST_TYPE="tests")	04 Oct 2018 10:57AM UTC	53.72	Travis Job 3919.8

Source Files on build 3919

Detailed source file information is not available for this build.

aiidateam / aiida_core / 3919
74%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3919

aiidateam / aiida_core / 3919 74%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3919

aiidateam / aiida_core / 3919
74%

README BADGES
x