1
58%
master: 92%

Ran 15 Sep 2018 03:52AM UTC

Files 25

Run time 1s

Badge

Embed ▾

Committed 15 Sep 2018 03:50AM UTC coverage: 57.895% (+0.02%) from 57.877%

Job # 2.4.4

Build Type

Pull #289

travis-ci

Committed by

web-flow

Commit Message

Tweak BundleContextController and rework tests

No need to separately `find_by` when rspec gives us the `assigns`
method.  It gives the tests access to the **same** object the template would
receive (even better than a different object -- or `nil` -- returned by
`find_by`).

Uses devise helper `sign_in` method and removes hardcoded `User.create`
in controller (meaning only one object could ever be created, since the
subsequent `User.create` would certainly fail).

Controller is not concerned with Job directly, only with creating a
`JobRun` object.

`current_user` is one of the `bundle_context_params`, logically.  Pass
it to `.create`.

`bundle_input_b` doesn't exist anymore, and the model still requires the
`bundle_dir` to exist to be valid (and saved). Changed it to `smpl_multimedia`.

This fixes the build.

Pull Request Pull Request #289: Tweak BundleContextController and rework tests

Run Details

528 of 912 relevant lines covered (57.89%)

15.01 hits per line

sul-dlss / pre-assembly / 890 / 1
58%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 890.1 (2.4.4)

sul-dlss / pre-assembly / 890 / 1 58% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 890.1 (2.4.4)

sul-dlss / pre-assembly / 890 / 1
58%
master: 92%

README BADGES
x