• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

sul-dlss / pre-assembly / 890
58%
master: 92%

Build:
Build:
LAST BUILD BRANCH: circleci-codeclimate
DEFAULT BRANCH: master
Ran 15 Sep 2018 03:52AM UTC
Jobs 1
Files 25
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
890

Pull #289

travis-ci

web-flow
Tweak BundleContextController and rework tests

No need to separately `find_by` when rspec gives us the `assigns`
method.  It gives the tests access to the **same** object the template would
receive (even better than a different object -- or `nil` -- returned by
`find_by`).

Uses devise helper `sign_in` method and removes hardcoded `User.create`
in controller (meaning only one object could ever be created, since the
subsequent `User.create` would certainly fail).

Controller is not concerned with Job directly, only with creating a
`JobRun` object.

`current_user` is one of the `bundle_context_params`, logically.  Pass
it to `.create`.

`bundle_input_b` doesn't exist anymore, and the model still requires the
`bundle_dir` to exist to be valid (and saved). Changed it to `smpl_multimedia`.

This fixes the build.
Pull Request #289: Tweak BundleContextController and rework tests

4 of 4 new or added lines in 1 file covered. (100.0%)

528 of 912 relevant lines covered (57.89%)

15.01 hits per line

Jobs
ID Job ID Ran Files Coverage
1 890.1 (2.4.4) 15 Sep 2018 03:52AM UTC 0
57.89
Travis Job 890.1
Source Files on build 890
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #890
  • Pull Request #289
  • PR Base - master (#887)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc