3
96%
master: 96%

Ran 04 Sep 2018 06:00AM UTC

Files 12

Run time 0s

Badge

Embed ▾

Committed 04 Sep 2018 05:58AM UTC coverage: 98.592%. Remained the same

Job # 451.3

Build Type

push

travis-ci

Committed by

lqez

Commit Message

fix widget repeat rendering

If pop is used to get the value of 'summernote' on self.attrs, then the html returned by render() may change after the first call.  For example:
```python
w=SummernoteWidget(attrs={'summernote':{'height':'123px'}})
w.render('test','',attrs={'id':'test'})
```
Will render the iframe height as '123px', however a second call 
```python
w.render('test','',attrs={'id':'test'})
```
will render whatever the default value for height is instead of '123px' because the summernote value of attrs was popped in the first call and therefore is no longer available for subsequent calls.

This PR fixes that by chaning the self.attrs.pop('summernote', {}) calls in both widgets to self.attrs.get('summernote', {})

Run Details

280 of 284 relevant lines covered (98.59%)

0.99 hits per line

summernote / django-summernote / 451 / 3
96%
master: 96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 451.3

summernote / django-summernote / 451 / 3 96% master: 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 451.3

summernote / django-summernote / 451 / 3
96%
master: 96%

README BADGES
x