451
96%

Ran 04 Sep 2018 05:59AM UTC

Jobs 3

Files 12

Run time 47s

Badge

Embed ▾

pending completion

Build # 451

Build Type

push

travis-ci

Committed by

lqez

Commit Message

fix widget repeat rendering

If pop is used to get the value of 'summernote' on self.attrs, then the html returned by render() may change after the first call.  For example:
```python
w=SummernoteWidget(attrs={'summernote':{'height':'123px'}})
w.render('test','',attrs={'id':'test'})
```
Will render the iframe height as '123px', however a second call 
```python
w.render('test','',attrs={'id':'test'})
```
will render whatever the default value for height is instead of '123px' because the summernote value of attrs was popped in the first call and therefore is no longer available for subsequent calls.

This PR fixes that by chaning the self.attrs.pop('summernote', {}) calls in both widgets to self.attrs.get('summernote', {})

Run Details

280 of 284 relevant lines covered (98.59%)

2.96 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	451.1	04 Sep 2018 05:59AM UTC	98.59	Travis Job 451.1
2	451.2	04 Sep 2018 06:00AM UTC	98.59	Travis Job 451.2
3	451.3	04 Sep 2018 06:00AM UTC	98.59	Travis Job 451.3

Source Files on build 451

Detailed source file information is not available for this build.

summernote / django-summernote / 451
96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 451

summernote / django-summernote / 451 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 451

summernote / django-summernote / 451
96%

README BADGES
x