1
93%
master: 94%

Ran 14 Aug 2018 02:39PM UTC

Files 90

Run time 8s

Badge

Embed ▾

Committed 14 Aug 2018 02:32PM UTC coverage: 92.811%. Remained the same

Job # 4663.1

Build Type

Pull #903

travis-ci

Committed by

web-flow

Commit Message

XmlAdaptedPerson#toModelType(): remove shadowing of fields

The method body references the fields of XmlAdaptedPerson (`name`,
`phone`, etc.), but also shadows them later on by declaring local
variables with the same name.

Such mixing of instance fields and local variables within the same
method is out of the ordinary in the code base, and can be accidentally
mis-read if the reader is not paying attention.

Let's take the path of least surprise by renaming the local variables
such that they do not shadow XmlAdaptedPerson's fields.

Pull Request Pull Request #903: Remove unnecessary uses of `this`

Coverage Stats

1433 of 1544 relevant lines covered (92.81%)

0.93 hits per line

se-edu / addressbook-level4 / 4663 / 1
93%
master: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4663.1

se-edu / addressbook-level4 / 4663 / 1 93% master: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4663.1

se-edu / addressbook-level4 / 4663 / 1
93%
master: 94%

README BADGES
x