• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

se-edu / addressbook-level4 / 4663
93%
master: 94%

Build:
Build:
LAST BUILD BRANCH: 453-result-message
DEFAULT BRANCH: master
Ran 14 Aug 2018 02:39PM UTC
Jobs 1
Files 90
Run time 10s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
4663

Pull #903

travis-ci

web-flow
XmlAdaptedPerson#toModelType(): remove shadowing of fields

The method body references the fields of XmlAdaptedPerson (`name`,
`phone`, etc.), but also shadows them later on by declaring local
variables with the same name.

Such mixing of instance fields and local variables within the same
method is out of the ordinary in the code base, and can be accidentally
mis-read if the reader is not paying attention.

Let's take the path of least surprise by renaming the local variables
such that they do not shadow XmlAdaptedPerson's fields.
Pull Request #903: Remove unnecessary uses of `this`

66 of 66 new or added lines in 27 files covered. (100.0%)

1433 of 1544 relevant lines covered (92.81%)

0.93 hits per line

Jobs
ID Job ID Ran Files Coverage
1 4663.1 14 Aug 2018 02:39PM UTC 0
92.81
Travis Job 4663.1
Source Files on build 4663
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #4663
  • Pull Request #903
  • PR Base - master (#4660)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc