se-edu / addressbook-level4 / 4663

93%

master: 94%

Pull #903

travis-ci

XmlAdaptedPerson#toModelType(): remove shadowing of fields

The method body references the fields of XmlAdaptedPerson (`name`,
`phone`, etc.), but also shadows them later on by declaring local
variables with the same name.

Such mixing of instance fields and local variables within the same
method is out of the ordinary in the code base, and can be accidentally
mis-read if the reader is not paying attention.

Let's take the path of least surprise by renaming the local variables
such that they do not shadow XmlAdaptedPerson's fields.

66 of 66 new or added lines in 27 files covered. (100.0%)

1433 of 1544 relevant lines covered (92.81%)

0.93 hits per line