1
71%
master: 71%

Ran 08 Aug 2018 03:51PM UTC

Files 33

Run time 3s

Badge

Embed ▾

Committed 08 Aug 2018 03:49PM UTC coverage: 70.37% (-0.1%) from 70.476%

Job # 16.1

Build Type

Pull #30

travis-ci

Committed by

web-flow

Commit Message

fix ctypes.util.find_library usage

Per https://docs.python.org/2/library/ctypes.html the find_library
function should be called "without any prefix like lib, suffix like .so,
.dylib or version number".

 - change _LIBRARY_NAME from "libarchive" to "archive" as required

 - move find_library logic after the *_LIBRARY_PATH logic to preserve
   current behavior. I suspect that the LD_LIBRARY_PATH logic is not
   actually necessary, but a side effect of this bug. I'm leaving it
   alone because I can't test all existing configurations to confirm
   that.

 - if find_library returns a result, use it unconditionally. Trying to
   confirm it is unnecessary (find_library would have returned None
   otherwise) and impossible without duplicating all of the linker's
   logic. The result will be something like "libarchive.so.13" (without
   a path) which will just do the right thing when used with LoadLibrary.

 - remove note about installing libarchive-dev, that isn't needed

Pull Request Pull Request #30: fix ctypes.util.find_library usage

Run Details

665 of 945 relevant lines covered (70.37%)

0.7 hits per line

dsoprea / PyEasyArchive / 16 / 1
71%
master: 71%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 16.1

dsoprea / PyEasyArchive / 16 / 1 71% master: 71%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 16.1

dsoprea / PyEasyArchive / 16 / 1
71%
master: 71%

README BADGES
x