dsoprea / PyEasyArchive / 16

71%

Pull #30

travis-ci

fix ctypes.util.find_library usage

Per https://docs.python.org/2/library/ctypes.html the find_library
function should be called "without any prefix like lib, suffix like .so,
.dylib or version number".

 - change _LIBRARY_NAME from "libarchive" to "archive" as required

 - move find_library logic after the *_LIBRARY_PATH logic to preserve
   current behavior. I suspect that the LD_LIBRARY_PATH logic is not
   actually necessary, but a side effect of this bug. I'm leaving it
   alone because I can't test all existing configurations to confirm
   that.

 - if find_library returns a result, use it unconditionally. Trying to
   confirm it is unnecessary (find_library would have returned None
   otherwise) and impossible without duplicating all of the linker's
   logic. The result will be something like "libarchive.so.13" (without
   a path) which will just do the right thing when used with LoadLibrary.

 - remove note about installing libarchive-dev, that isn't needed

4 of 4 new or added lines in 1 file covered. (100.0%)

665 of 945 relevant lines covered (70.37%)

0.7 hits per line