2
47%
master: 46%

Ran 04 Aug 2018 04:12PM UTC

Files 87

Run time 4s

Badge

Embed ▾

Committed 04 Aug 2018 08:08AM UTC coverage: 47.322% (+0.01%) from 47.31%

Job # TOX_ENV=py34

Build Type

Pull #3261

travis-ci

Committed by

web-flow

Commit Message

Make base_badge_price actually store correct price
Fixes MAGDEV-254.

One of the entire points of base_badge_price was to allow us to store what the badge WOULD have cost if it were a regular attendee badge... a purpose we completely undermined by putting discounted and overridden prices in the calculation we used for base_badge_price. Most noticeably, this led us to charging dealers whose apps had been rejected only the dealer price, not the attendee price at the time they applied. We've instead moved ALL discounts and overrides to calculate_badge_cost, so they get applied to any price except the "base" price.

Thank goodness for unit tests.

Pull Request Pull Request #3261: Make base_badge_price actually store correct price

Run Details

6264 of 13237 relevant lines covered (47.32%)

0.47 hits per line

magfest / ubersystem / 5496 / 2
47%
master: 46%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5496.2 (TOX_ENV=py34)

magfest / ubersystem / 5496 / 2 47% master: 46%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5496.2 (TOX_ENV=py34)

magfest / ubersystem / 5496 / 2
47%
master: 46%

README BADGES
x