magfest / ubersystem / 5496

47%

master: 46%

Pull #3261

travis-ci

Make base_badge_price actually store correct price
Fixes MAGDEV-254.

One of the entire points of base_badge_price was to allow us to store what the badge WOULD have cost if it were a regular attendee badge... a purpose we completely undermined by putting discounted and overridden prices in the calculation we used for base_badge_price. Most noticeably, this led us to charging dealers whose apps had been rejected only the dealer price, not the attendee price at the time they applied. We've instead moved ALL discounts and overrides to calculate_badge_cost, so they get applied to any price except the "base" price.

Thank goodness for unit tests.

10 of 10 new or added lines in 1 file covered. (100.0%)

6264 of 13237 relevant lines covered (47.32%)

0.47 hits per line