• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

FriendsOfPHP / PHP-CS-Fixer / 2284 / 4
93%
master: 93%

Build:
DEFAULT BRANCH: master
Ran 04 Jan 2015 04:00PM UTC
Files 93
Run time 44s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

04 Jan 2015 03:59PM UTC coverage: 81.815% (+0.01%) from 81.804%
2284.4

push

travis-ci

Dariusz Rumiński
bug #952 ParenthesisFixer - fix case with list call with trailing comma (keradus)

This PR was merged into the 2.0-dev branch.

Discussion
----------

ParenthesisFixer - fix case with list call with trailing comma

Fix #930
Note: Should be merged into 1.4 branch as setted in milestone, not master as setted in PR.

Consider following code:
`<?php list($path, $mode,) = foo();`

If we run MethodArgumentSpaceFixer on it, it will add a space after comma:
`<?php list($path, $mode, ) = foo();`

Then if we run ParenthesisFixer it will remove that space:
`<?php list($path, $mode,) = foo();`

This PR change behavior of ParenthesisFixer - stop removing space if there is trailing comma.
Also added a tests for it in both fixers.

Commits
-------

b02b097 ParenthesisFixer - fix case with list call with trailing comma

2695 of 3294 relevant lines covered (81.82%)

51.39 hits per line

Source Files on job 2284.4
  • Tree
  • List 0
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Build 2284
  • Travis Job 2284.4
  • f538747f on github
  • Prev Job for on master (#2278.4)
  • Next Job for on master (#2287.5)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc