• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

FriendsOfPHP / PHP-CS-Fixer / 2284
93%

Build:
DEFAULT BRANCH: master
Ran 04 Jan 2015 03:59PM UTC
Jobs 5
Files 93
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2284

push

travis-ci

Dariusz Rumiński
bug #952 ParenthesisFixer - fix case with list call with trailing comma (keradus)

This PR was merged into the 2.0-dev branch.

Discussion
----------

ParenthesisFixer - fix case with list call with trailing comma

Fix #930
Note: Should be merged into 1.4 branch as setted in milestone, not master as setted in PR.

Consider following code:
`<?php list($path, $mode,) = foo();`

If we run MethodArgumentSpaceFixer on it, it will add a space after comma:
`<?php list($path, $mode, ) = foo();`

Then if we run ParenthesisFixer it will remove that space:
`<?php list($path, $mode,) = foo();`

This PR change behavior of ParenthesisFixer - stop removing space if there is trailing comma.
Also added a tests for it in both fixers.

Commits
-------

b02b097 ParenthesisFixer - fix case with list call with trailing comma

2873 of 3472 relevant lines covered (82.75%)

201.56 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2284.1 04 Jan 2015 03:58PM UTC 0
81.42
Travis Job 2284.1
2 2284.2 04 Jan 2015 03:58PM UTC 0
81.69
Travis Job 2284.2
3 2284.3 04 Jan 2015 03:58PM UTC 0
81.82
Travis Job 2284.3
4 2284.4 04 Jan 2015 03:58PM UTC 0
81.82
Travis Job 2284.4
5 2284.5 04 Jan 2015 03:58PM UTC 0
74.35
Travis Job 2284.5
Source Files on build 2284
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2284
  • f538747f on github
  • Prev Build on master (#2278)
  • Next Build on master (#2287)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc