• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

reactjs / react-modal / 862 / 1
85%
master: 85%

Build:
DEFAULT BRANCH: master
Ran 30 Jul 2018 04:50PM UTC
Files 9
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

30 Jul 2018 04:48PM UTC coverage: 87.703%. Remained the same
862.1

push

travis-ci

diasbruno
[fixed] remove aria-modal attr to prevent browser bugs

There were a couple problems with the aria-modal attribute:

- it was not set on the correct dom element (in theory, it should be
set on the element having the dialog role, as stated in #654)
- it is buggy in Safari. The easy way to fix the problem is to remove the attribute
(again, as suggested in #654). While it's cool on paper, the attribute is currently
not necessary, since the `aria-hidden="true"` is set correctly on the
app element.

261 of 370 branches covered (70.54%)

378 of 431 relevant lines covered (87.7%)

38.44 hits per line

Source Files on job 862.1
  • Tree
  • List 0
  • Changed 1
  • Source Changed 1
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 798
  • Travis Job 862.1
  • 1e349c07 on github
  • Prev Job for on master (#858.1)
  • Next Job for on master (#864.1)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc