reactjs / react-modal / 862

85%

push

travis-ci

[fixed] remove aria-modal attr to prevent browser bugs

There were a couple problems with the aria-modal attribute:

- it was not set on the correct dom element (in theory, it should be
set on the element having the dialog role, as stated in #654)
- it is buggy in Safari. The easy way to fix the problem is to remove the attribute
(again, as suggested in #654). While it's cool on paper, the attribute is currently
not necessary, since the `aria-hidden="true"` is set correctly on the
app element.

261 of 370 branches covered (70.54%)

378 of 431 relevant lines covered (87.7%)

38.44 hits per line