4
94%
dev: 94%

Ran 29 Jun 2018 11:09PM UTC

Files 407

Run time 20s

Badge

Embed ▾

Committed 29 Jun 2018 10:59PM UTC coverage: 94.131%. Remained the same

Job # TOXENV=py35

Build Type

push

travis-ci

Committed by

Kane610

Commit Message

deconz: fix light.turn_off with transition (#15222)

When light.turn_off is invoked with a transition, the following payload was
sent to deCONZ via PUT to /light/N/state:

{ "bri": 0, "transitiontime": transition }

However, on recent versions of deCONZ (latest is 2.05.31 at the time of
writing) this does not turn off the light, just sets it to minimum brightness
level (brightness is clamped to minimum level the light supports without
turning it off).

This commit makes the code send this payload instead:

{ "on": false, "transitiontime": transition }

This works as intended and the light does transition to the 'off' state.
This change was tested with Philips Hue colored lights, IKEA colored lights
and IKEA white spectrum lights: they were all able to be turned off
successfully with the new payload, and none of them could be turned off with
the old payload.

Coverage Stats

36151 of 38405 relevant lines covered (94.13%)

0.94 hits per line

home-assistant / home-assistant / 45790 / 4
94%
dev: 94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 45790.4 (TOXENV=py35)

home-assistant / home-assistant / 45790 / 4 94% dev: 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 45790.4 (TOXENV=py35)

home-assistant / home-assistant / 45790 / 4
94%
dev: 94%

README BADGES
x