45790
94%

Ran 29 Jun 2018 11:01PM UTC

Jobs 5

Files 407

Run time 12min

Badge

Embed ▾

pending completion

Build # 45790

Build Type

push

travis-ci

Committed by

Kane610

Commit Message

deconz: fix light.turn_off with transition (#15222)

When light.turn_off is invoked with a transition, the following payload was
sent to deCONZ via PUT to /light/N/state:

{ "bri": 0, "transitiontime": transition }

However, on recent versions of deCONZ (latest is 2.05.31 at the time of
writing) this does not turn off the light, just sets it to minimum brightness
level (brightness is clamped to minimum level the light supports without
turning it off).

This commit makes the code send this payload instead:

{ "on": false, "transitiontime": transition }

This works as intended and the light does transition to the 'off' state.
This change was tested with Philips Hue colored lights, IKEA colored lights
and IKEA white spectrum lights: they were all able to be turned off
successfully with the new payload, and none of them could be turned off with
the old payload.

Coverage Stats

36153 of 38405 relevant lines covered (94.14%)

1.88 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	45790.1 (TOXENV=lint)	29 Jun 2018 11:03PM UTC		Travis Job 45790.1
2	45790.2 (TOXENV=pylint)	29 Jun 2018 11:13PM UTC		Travis Job 45790.2
3	45790.3 (TOXENV=typing)	29 Jun 2018 11:01PM UTC		Travis Job 45790.3
4	45790.4 (TOXENV=py35)	29 Jun 2018 11:09PM UTC	94.13	Travis Job 45790.4
5	45790.5 (TOXENV=py36)	29 Jun 2018 11:06PM UTC	94.13	Travis Job 45790.5

Source Files on build 45790

Detailed source file information is not available for this build.

home-assistant / home-assistant / 45790
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 45790

home-assistant / home-assistant / 45790 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 45790

home-assistant / home-assistant / 45790
94%

README BADGES
x