1
49%
master: 49%

Ran 31 May 2018 06:41PM UTC

Files 51

Run time 2min

Badge

Embed ▾

Committed 31 May 2018 06:39PM UTC coverage: 89.154% (+38.8%) from 50.308%

Job # 139.1

Build Type

Pull #30

travis-ci

Committed by

web-flow

Commit Message

Properly handle implicit conversion to integer types.

Go's reflect API is very picky about arguments to Call method. You can't just
pass in the "int" when function expects "int64", even on 64 bit machines. This
patch solves this problem by performing conversions properly. Truncation
problems however, as well as negative to uint issues are completely ignored.
Which is perhaps not ideal, but still better than returning "int" when "int32"
or "int64" is requested.

I did split the Kind switch cases and moved value -> int and value -> float
conversions to separate functions. An alternative to that would be using the
reflection API, which might be less performant. Not that it matters much, but
this solution is correct, even though looks a bit copy & pasty.

Oh and of course all "uint" types were completely missing in the function and
they are now added.

Pull Request Pull Request #30: Properly handle implicit conversion to integer types.

Run Details

2655 of 2978 relevant lines covered (89.15%)

591.83 hits per line

osteele / liquid / 139 / 1
49%
master: 49%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 139.1

osteele / liquid / 139 / 1 49% master: 49%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 139.1

osteele / liquid / 139 / 1
49%
master: 49%

README BADGES
x