• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

osteele / liquid / 139
49%

Build:
DEFAULT BRANCH: master
Ran 31 May 2018 06:41PM UTC
Jobs 2
Files 51
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
139

Pull #30

travis-ci

web-flow
Properly handle implicit conversion to integer types.

Go's reflect API is very picky about arguments to Call method. You can't just
pass in the "int" when function expects "int64", even on 64 bit machines. This
patch solves this problem by performing conversions properly. Truncation
problems however, as well as negative to uint issues are completely ignored.
Which is perhaps not ideal, but still better than returning "int" when "int32"
or "int64" is requested.

I did split the Kind switch cases and moved value -> int and value -> float
conversions to separate functions. An alternative to that would be using the
reflection API, which might be less performant. Not that it matters much, but
this solution is correct, even though looks a bit copy & pasty.

Oh and of course all "uint" types were completely missing in the function and
they are now added.
Pull Request #30: Properly handle implicit conversion to integer types.

51 of 51 new or added lines in 1 file covered. (100.0%)

2655 of 2978 relevant lines covered (89.15%)

648.87 hits per line

Jobs
ID Job ID Ran Files Coverage
1 139.1 31 May 2018 06:41PM UTC 0
89.15
Travis Job 139.1
2 139.2 31 May 2018 06:41PM UTC 0
49.7
Travis Job 139.2
Source Files on build 139
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #139
  • Pull Request #30
  • PR Base - master (#138)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc