3
98%
master: 98%

Ran 22 May 2018 10:14PM UTC

Files 7

Run time 1s

Badge

Embed ▾

Committed 22 May 2018 10:10PM UTC coverage: 99.823% (+0.002%) from 99.821%

Job # TOXENV=py34-pylint14

Build Type

push

travis-ci

Committed by

moylop260

Commit Message

[ADD] Add new lint to detect variables within translatable strings (#198)

As stated in the Odoo documentation [1], when translations need to
reference variables, they should be outside the function `_(...)`,
because they might not work as expected. For example, expressions like
the following should be avoided:
`_("Scheduled meeting with %s" % invitee.name)`

Instead, the following should be used:
`_("Scheduled meeting with %s") % invitee.name`

This change adds a new lint to detect badly-former expressions like the
above, and to suggest the correct way to achieve the desired behavior.

In addition, this adds eight cases of badly-formed expressions. There
are in total ten expected errors, because there were already two cases:
- https://github.com/OCA/pylint-odoo/blob/8845b74/pylint_odoo/test_repo/broken_module/models/broken_model.py#L298
- https://github.com/OCA/pylint-odoo/blob/8845b74/pylint_odoo/test_repo/broken_module/models/broken_model.py#L302

[1] https://www.odoo.com/documentation/11.0/reference/translations.html#variables

Closes #194

Run Details

1127 of 1129 relevant lines covered (99.82%)

1.0 hits per line

OCA / pylint-odoo / 660 / 3
98%
master: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 660.3 (TOXENV=py34-pylint14)

OCA / pylint-odoo / 660 / 3 98% master: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 660.3 (TOXENV=py34-pylint14)

OCA / pylint-odoo / 660 / 3
98%
master: 98%

README BADGES
x