OCA / pylint-odoo / 660

98%

push

travis-ci

[ADD] Add new lint to detect variables within translatable strings (#198)

As stated in the Odoo documentation [1], when translations need to
reference variables, they should be outside the function `_(...)`,
because they might not work as expected. For example, expressions like
the following should be avoided:
`_("Scheduled meeting with %s" % invitee.name)`

Instead, the following should be used:
`_("Scheduled meeting with %s") % invitee.name`

This change adds a new lint to detect badly-former expressions like the
above, and to suggest the correct way to achieve the desired behavior.

In addition, this adds eight cases of badly-formed expressions. There
are in total ten expected errors, because there were already two cases:
- https://github.com/OCA/pylint-odoo/blob/8845b74/pylint_odoo/test_repo/broken_module/models/broken_model.py#L298
- https://github.com/OCA/pylint-odoo/blob/8845b74/pylint_odoo/test_repo/broken_module/models/broken_model.py#L302

[1] https://www.odoo.com/documentation/11.0/reference/translations.html#variables

Closes #194

12 of 12 new or added lines in 1 file covered. (100.0%)

1129 of 1129 relevant lines covered (100.0%)

4.0 hits per line