1
82%
master: 82%

Ran 02 Apr 2018 03:28AM UTC

Files 56

Run time 1s

Badge

Embed ▾

Committed 02 Apr 2018 03:22AM UTC coverage: 95.519% (+0.1%) from 95.395%

Job # 792.1

Build Type

push

travis-ci

Committed by

WillemJiang

Commit Message

refactor method TxEventRepository.findFirstUncompensatedEventByIdGreaterThan()

Change method signature from
  List<TxEvent> findFirstUncompensatedEventByIdGreaterThan(long id, String type);
to
  Optional<TxEvent> findFirstUncompensatedEventByIdGreaterThan(long id);

Reasons:

1. this method named "findFirst" and it always returns a list with 1 element
   or an empty list, so it's better to return Optional<>.
2. this method try to find a TxEndedEvent which is aborted but not compensated, so
   the parameter type should not be exposed to callers, it should be in internal
   query logic.

Run Details

874 of 915 relevant lines covered (95.52%)

1.63 hits per line

apache / servicecomb-pack / 792 / 1
82%
master: 82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 792.1

apache / servicecomb-pack / 792 / 1 82% master: 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 792.1

apache / servicecomb-pack / 792 / 1
82%
master: 82%

README BADGES
x