792
82%

Ran 02 Apr 2018 03:28AM UTC

Jobs 1

Files 56

Run time 6s

Badge

Embed ▾

pending completion

Build # 792

Build Type

push

travis-ci

Committed by

WillemJiang

Commit Message

refactor method TxEventRepository.findFirstUncompensatedEventByIdGreaterThan()

Change method signature from
  List<TxEvent> findFirstUncompensatedEventByIdGreaterThan(long id, String type);
to
  Optional<TxEvent> findFirstUncompensatedEventByIdGreaterThan(long id);

Reasons:

1. this method named "findFirst" and it always returns a list with 1 element
   or an empty list, so it's better to return Optional<>.
2. this method try to find a TxEndedEvent which is aborted but not compensated, so
   the parameter type should not be exposed to callers, it should be in internal
   query logic.

Run Details

874 of 915 relevant lines covered (95.52%)

1.63 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	792.1	02 Apr 2018 03:28AM UTC	0	95.52	Travis Job 792.1

Source Files on build 792

Detailed source file information is not available for this build.

apache / servicecomb-pack / 792
82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 792

apache / servicecomb-pack / 792 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 792

apache / servicecomb-pack / 792
82%

README BADGES
x