1
82%
master: 82%

Ran 01 Apr 2018 09:14AM UTC

Files 56

Run time 3s

Badge

Embed ▾

Committed 01 Apr 2018 09:09AM UTC coverage: 95.301% (-0.09%) from 95.395%

Job # 791.1

Build Type

Pull #166

travis-ci

Committed by

web-flow

Commit Message

refactor method TxEventRepository.findFirstUncompensatedEventByIdGreaterThan()

Change method signature from
  List<TxEvent> findFirstUncompensatedEventByIdGreaterThan(long id, String type);
to
  Optional<TxEvent> findFirstUncompensatedEventByIdGreaterThan(long id);

Reasons:

1. this method named "findFirst" and it always returns a list with 1 element
   or an empty list, so it's better to return Optional<>.
2. this method try to find a TxEndedEvent which is aborted but not compensated, so
   the parameter type should not be exposed to callers, it should be in internal
   query logic.

Pull Request Pull Request #166: [SCB-452] Write java doc for some class and some refactoring.

Coverage Stats

872 of 915 relevant lines covered (95.3%)

1.63 hits per line

apache / servicecomb-pack / 791 / 1
82%
master: 82%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 791.1

apache / servicecomb-pack / 791 / 1 82% master: 82%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 791.1

apache / servicecomb-pack / 791 / 1
82%
master: 82%

README BADGES
x