apache / servicecomb-pack / 791

82%

Pull #166

travis-ci

refactor method TxEventRepository.findFirstUncompensatedEventByIdGreaterThan()

Change method signature from
  List<TxEvent> findFirstUncompensatedEventByIdGreaterThan(long id, String type);
to
  Optional<TxEvent> findFirstUncompensatedEventByIdGreaterThan(long id);

Reasons:

1. this method named "findFirst" and it always returns a list with 1 element
   or an empty list, so it's better to return Optional<>.
2. this method try to find a TxEndedEvent which is aborted but not compensated, so
   the parameter type should not be exposed to callers, it should be in internal
   query logic.

9 of 9 new or added lines in 2 files covered. (100.0%)

872 of 915 relevant lines covered (95.3%)

1.63 hits per line