3
71%
master: 71%

Ran 23 Mar 2018 09:57PM UTC

Files 4

Run time 0s

Badge

Embed ▾

Committed 23 Mar 2018 09:54PM UTC coverage: 61.654% (+14.4%) from 47.251%

Job # 1147.3

Build Type

Pull #501

travis-ci

Committed by

web-flow

Commit Message

Fix bug with jobs not being marked as completed.

* A bug was introduced with getting the replica status in #344 which
switched to creating pods directly.

* Our presubmits/postsubmits were failing but this went unnoticed because
the git status check was improperly reported as succeeded.

* The bug is because we try to get the pod status by name but the name
doesn't include the random salt in the pod name.

* The code in question is a legacy of when we were using job controllers and
we first got the status of the job controller. We incorrectly changed that
code to get the pod. The correct thing is to just list pods by label; we
already do that in the code below so we just need to delete some code.

* Fix #500

Pull Request Pull Request #501: Fix bug with jobs not being marked as completed.

Coverage Stats

82 of 133 relevant lines covered (61.65%)

3.01 hits per line

kubeflow / tf-operator / 1147 / 3
71%
master: 71%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1147.3

kubeflow / tf-operator / 1147 / 3 71% master: 71%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 1147.3

kubeflow / tf-operator / 1147 / 3
71%
master: 71%

README BADGES
x