1147
71%

Ran 23 Mar 2018 09:57PM UTC

Jobs 3

Files 10

Run time 7min

Badge

Embed ▾

pending completion

Build # 1147

Build Type

Pull #501

travis-ci

Committed by

web-flow

Commit Message

Fix bug with jobs not being marked as completed.

* A bug was introduced with getting the replica status in #344 which
switched to creating pods directly.

* Our presubmits/postsubmits were failing but this went unnoticed because
the git status check was improperly reported as succeeded.

* The bug is because we try to get the pod status by name but the name
doesn't include the random salt in the pod name.

* The code in question is a legacy of when we were using job controllers and
we first got the status of the job controller. We incorrectly changed that
code to get the pod. The correct thing is to just list pods by label; we
already do that in the code below so we just need to delete some code.

* Fix #500

Pull Request Pull Request #501: Fix bug with jobs not being marked as completed.

Run Details

446 of 974 relevant lines covered (45.79%)

5.37 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	1147.1	23 Mar 2018 10:04PM UTC	47.84	Travis Job 1147.1
2	1147.2	23 Mar 2018 10:03PM UTC	47.84	Travis Job 1147.2
3	1147.3	23 Mar 2018 09:57PM UTC	61.65	Travis Job 1147.3

Source Files on build 1147

Detailed source file information is not available for this build.

kubeflow / tf-operator / 1147
71%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1147

kubeflow / tf-operator / 1147 71%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1147

kubeflow / tf-operator / 1147
71%

README BADGES
x