1
88%
master: 88%

Ran 18 Nov 2014 12:05AM UTC

Files 18

Run time 9s

Badge

Embed ▾

Committed 04 Oct 2014 10:15PM UTC coverage: 93.841% (+1.4%) from 92.447%

Job # 247.1

Build Type

push

travis-ci

Committed by

oconnor663

Commit Message

turn Rule.do_build into a coroutine

Summary:
Build commands now run in parallel with fetches, so a long-running build
command won't block progress on the main thread. We still limit
ourselves to one build command at a time, to avoid thrashing the disk,
and so that we can safely forward build command output straight to the
console without interleaving.

To make this easy, we add a `get_printing_handle` to `BaseDisplay`. This
handle implements the interface of a regular display handle, but just
calls the display's `print` method instead of doing anything fancy. That
lets us share `create_subprocess_with_handle` between modules and rules
without any other changes.

Test Plan:
Added an integration test for fetch and build output that also
conveniently fails if the cache checks or locks are removed for either
rules or modules. (That causes the build or fetch to occur and print
multiple times, disrupting the output.)

Reviewers: sean

Reviewed By: sean

Differential Revision: https://phabricator.buildinspace.com/D105

Run Details

899 of 958 relevant lines covered (93.84%)

0.94 hits per line

buildinspace / peru / 247 / 1
88%
master: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 247.1

buildinspace / peru / 247 / 1 88% master: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 247.1

buildinspace / peru / 247 / 1
88%
master: 88%

README BADGES
x