247
88%

Ran 04 Oct 2014 10:18PM UTC

Jobs 2

Files 18

Run time 63558min

Badge

Embed ▾

pending completion

Build # 247

Build Type

push

travis-ci

Committed by

oconnor663

Commit Message

turn Rule.do_build into a coroutine

Summary:
Build commands now run in parallel with fetches, so a long-running build
command won't block progress on the main thread. We still limit
ourselves to one build command at a time, to avoid thrashing the disk,
and so that we can safely forward build command output straight to the
console without interleaving.

To make this easy, we add a `get_printing_handle` to `BaseDisplay`. This
handle implements the interface of a regular display handle, but just
calls the display's `print` method instead of doing anything fancy. That
lets us share `create_subprocess_with_handle` between modules and rules
without any other changes.

Test Plan:
Added an integration test for fetch and build output that also
conveniently fails if the cache checks or locks are removed for either
rules or modules. (That causes the build or fetch to occur and print
multiple times, disrupting the output.)

Reviewers: sean

Reviewed By: sean

Differential Revision: https://phabricator.buildinspace.com/D105

Run Details

413 of 449 relevant lines covered (91.98%)

1.84 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	247.1	18 Nov 2014 12:05AM UTC	0	93.84	Travis Job 247.1
2	247.2	18 Nov 2014 01:36AM UTC	0	91.76	Travis Job 247.2

Source Files on build 247

Detailed source file information is not available for this build.

buildinspace / peru / 247
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 247

buildinspace / peru / 247 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 247

buildinspace / peru / 247
88%

README BADGES
x