1
88%
master: 88%

Ran 18 Nov 2014 12:00AM UTC

Files 17

Run time 8s

Badge

Embed ▾

Committed 23 Sep 2014 02:58AM UTC coverage: 94.774% (+1.4%) from 93.333%

Job # 241.1

Build Type

push

travis-ci

Committed by

oconnor663

Commit Message

add context to module field error messages

Summary:
We have several important checks (like invalid module field names) that
are still `assert`s from back before we had any kind of UI. Replace
these with proper `PrintableErrors`, and include maybe-kinda-sorta
important information like the name of the invalid field.

I'm removing the check for whitespace in plugin field names. If the
plugin author wants to define a field with space in it, that's now
possible, though we should consider supporting it a little better. See
https://github.com/buildinspace/peru/issues/51.

Test Plan:
I exercised all these errors by hand to make sure the printouts looked
good. I've added actual tests for some of them, to confirm that field
information is actually present in the message.

Reviewers: sean

Differential Revision: https://phabricator.buildinspace.com/D93

Coverage Stats

399 of 421 relevant lines covered (94.77%)

0.95 hits per line

buildinspace / peru / 241 / 1
88%
master: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 241.1

buildinspace / peru / 241 / 1 88% master: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 241.1

buildinspace / peru / 241 / 1
88%
master: 88%

README BADGES
x