241
88%

Ran 23 Sep 2014 03:00AM UTC

Jobs 2

Files 17

Run time 80462min

Badge

Embed ▾

pending completion

Build # 241

Build Type

push

travis-ci

Committed by

oconnor663

Commit Message

add context to module field error messages

Summary:
We have several important checks (like invalid module field names) that
are still `assert`s from back before we had any kind of UI. Replace
these with proper `PrintableErrors`, and include maybe-kinda-sorta
important information like the name of the invalid field.

I'm removing the check for whitespace in plugin field names. If the
plugin author wants to define a field with space in it, that's now
possible, though we should consider supporting it a little better. See
https://github.com/buildinspace/peru/issues/51.

Test Plan:
I exercised all these errors by hand to make sure the printouts looked
good. I've added actual tests for some of them, to confirm that field
information is actually present in the message.

Reviewers: sean

Differential Revision: https://phabricator.buildinspace.com/D93

Run Details

944 of 989 relevant lines covered (95.45%)

1.36 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	241.1	18 Nov 2014 12:00AM UTC	0	94.77	Travis Job 241.1
2	241.2	18 Nov 2014 12:02AM UTC	0	95.45	Travis Job 241.2

Source Files on build 241

Detailed source file information is not available for this build.

buildinspace / peru / 241
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 241

buildinspace / peru / 241 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 241

buildinspace / peru / 241
88%

README BADGES
x