1
61%
master: 70%

Ran 24 Feb 2018 08:55PM UTC

Files 310

Run time 10s

Badge

Embed ▾

Committed 24 Feb 2018 08:16PM UTC coverage: 51.043%. First build

Job # MC_TEST_CHUNK=1

Build Type

push

travis-ci

Committed by

hroberts

Commit Message

Don't deep_copy or wantarray return value in HandlerProxy if the caller is python

When a database handle was created in perl and passed to python, the hashes() and flat() methods were returning
the single value rather than a list in python when the query returned only one row.  This is different than the
behavior when calling those functions from a python created db handle, so it was causing intermittent havoc in
python functions called from perl with a perl db handle.  The cause was that those methods were calling wantarray
in perl to figure out whether to return a list or a ref to a list, which was causing the return type confusion.

You can reproduce this issue by uncommenting the new code in HandlerProxy hashes() and running
lib/MediaWords/DB/t/HandlerProxy.t

In the theory of reducing unnecessary work and round trip complexity, I added a check to all of the deep_copy(
$return_value ) calls in HandlerProxy.pm to avoid the deep_copy if the caller is python.

Run Details

11057 of 21662 relevant lines covered (51.04%)

77.61 hits per line

berkmancenter / mediacloud / 4889 / 1
61%
master: 70%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4889.1 (MC_TEST_CHUNK=1)

berkmancenter / mediacloud / 4889 / 1 61% master: 70%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 4889.1 (MC_TEST_CHUNK=1)

berkmancenter / mediacloud / 4889 / 1
61%
master: 70%

README BADGES
x