4889
61%
master: 70%

Ran 24 Feb 2018 08:46PM UTC

Jobs 3

Files 327

Run time 9min

Badge

Embed ▾

pending completion

Build # 4889

Build Type

push

travis-ci

Committed by

hroberts

Commit Message

Don't deep_copy or wantarray return value in HandlerProxy if the caller is python

When a database handle was created in perl and passed to python, the hashes() and flat() methods were returning
the single value rather than a list in python when the query returned only one row.  This is different than the
behavior when calling those functions from a python created db handle, so it was causing intermittent havoc in
python functions called from perl with a perl db handle.  The cause was that those methods were calling wantarray
in perl to figure out whether to return a list or a ref to a list, which was causing the return type confusion.

You can reproduce this issue by uncommenting the new code in HandlerProxy hashes() and running
lib/MediaWords/DB/t/HandlerProxy.t

In the theory of reducing unnecessary work and round trip complexity, I added a check to all of the deep_copy(
$return_value ) calls in HandlerProxy.pm to avoid the deep_copy if the caller is python.

Run Details

13256 of 21953 relevant lines covered (60.38%)

477.0 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	4889.1 (MC_TEST_CHUNK=1)	24 Feb 2018 08:55PM UTC	51.04	Travis Job 4889.1
3	4889.3 (MC_TEST_CHUNK=3)	24 Feb 2018 08:48PM UTC	47.46	Travis Job 4889.3
4	4889.4 (MC_TEST_CHUNK=4)	24 Feb 2018 08:46PM UTC	53.62	Travis Job 4889.4

Source Files on build 4889

Detailed source file information is not available for this build.

berkmancenter / mediacloud / 4889
61%
master: 70%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4889

berkmancenter / mediacloud / 4889 61% master: 70%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4889

berkmancenter / mediacloud / 4889
61%
master: 70%

README BADGES
x