13
85%
master: 85%

Ran 12 Feb 2018 02:29PM UTC

Files 33

Run time 2s

Badge

Embed ▾

Committed 12 Feb 2018 02:04PM UTC coverage: 46.437%. Remained the same

Job # WALLABY_DRIVER=chrome

Build Type

push

travis-ci

Committed by

keathley

Commit Message

Fix zombie phantomjs processes (#338)

After running wallaby as part of a separate application, I confirmed we
were still leaving around zombie phantom processes. It turns out if we
kill the script's process group, it will kill all of the child processes
as well. This appears to fix the zombie issue once and for all.

One thing to note, I kill the process group by using the negative value
of the wrapper script's pid, instead of using `ps axo pid, pgid` to look
up the process group id. This is because I was occasionally running into
issues where the process group lookup wasn't returning a result, causing
more zombie processes. Hopefully this approach won't cause any issues.

Fixes #224.

Run Details

391 of 842 relevant lines covered (46.44%)

9784.05 hits per line

keathley / wallaby / 956 / 13
85%
master: 85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 956.13 (WALLABY_DRIVER=chrome)

keathley / wallaby / 956 / 13 85% master: 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 956.13 (WALLABY_DRIVER=chrome)

keathley / wallaby / 956 / 13
85%
master: 85%

README BADGES
x