956
85%

Ran 12 Feb 2018 02:09PM UTC

Jobs 13

Files 33

Run time 27min

Badge

Embed ▾

pending completion

Build # 956

Build Type

push

travis-ci

Committed by

keathley

Commit Message

Fix zombie phantomjs processes (#338)

After running wallaby as part of a separate application, I confirmed we
were still leaving around zombie phantom processes. It turns out if we
kill the script's process group, it will kill all of the child processes
as well. This appears to fix the zombie issue once and for all.

One thing to note, I kill the process group by using the negative value
of the wrapper script's pid, instead of using `ps axo pid, pgid` to look
up the process group id. This is because I was occasionally running into
issues where the process group lookup wasn't returning a result, causing
more zombie processes. Hopefully this approach won't cause any issues.

Fixes #224.

Run Details

744 of 842 relevant lines covered (88.36%)

157484.65 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	956.1	12 Feb 2018 02:19PM UTC	33	36.94	Travis Job 956.1
2	956.2 (WALLABY_DRIVER=phantom)	12 Feb 2018 02:09PM UTC	33	58.08	Travis Job 956.2
4	956.4 (WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=3)	12 Feb 2018 02:16PM UTC	33	37.05	Travis Job 956.4
6	956.6	12 Feb 2018 02:26PM UTC	33	36.94	Travis Job 956.6
7	956.7 (WALLABY_DRIVER=phantom)	12 Feb 2018 02:14PM UTC	33	58.08	Travis Job 956.7
8	956.8 (WALLABY_DRIVER=chrome)	12 Feb 2018 02:15PM UTC	33	43.35	Travis Job 956.8
9	956.9 (WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=3)	12 Feb 2018 02:27PM UTC	33	37.05	Travis Job 956.9
10	956.10 (WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=2)	12 Feb 2018 02:24PM UTC	33	37.17	Travis Job 956.10
11	956.11	12 Feb 2018 02:32PM UTC	33	43.11	Travis Job 956.11
12	956.12 (WALLABY_DRIVER=phantom)	12 Feb 2018 02:24PM UTC	33	61.88	Travis Job 956.12
13	956.13 (WALLABY_DRIVER=chrome)	12 Feb 2018 02:29PM UTC	33	46.44	Travis Job 956.13
14	956.14 (WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=3)	12 Feb 2018 02:37PM UTC	33	40.5	Travis Job 956.14
15	956.15 (WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=2)	12 Feb 2018 02:37PM UTC	33	40.5	Travis Job 956.15

Source Files on build 956

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

keathley / wallaby / 956
85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 956

keathley / wallaby / 956 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 956

keathley / wallaby / 956
85%

README BADGES
x