1
54%
master: 51%

Ran 22 Jan 2018 11:49PM UTC

Files 388

Run time 32s

Badge

Embed ▾

Committed 22 Jan 2018 11:22PM UTC coverage: 77.1% (-0.2%) from 77.318%

Job # 2.3.2, KNAPSACK_PRO_CI_NODE_INDEX=0

Build Type

push

travis-ci

Committed by

bertocq

Commit Message

Return 404 accesing community without communitable

Why:

Somehow we're seeing communities without proposals at production. We
must find why and fix it, but first we need to throw a 404 at the user
instead of a 500 internal server error

How:

First catching the scenario of non-existent communitable at the
controller and raising a 404 error. Secondly preventing the author_id
access over a possibly nil object, this is a smell but it can't be
easily fixed right now... we need to correctly implement a relation
between Community and communitable and avoid the multiple occurences of
`community.from_proposal?` in the codebase that makes it impossible to
extend to a fourth communitable model.

Coverage Stats

7545 of 9786 relevant lines covered (77.1%)

185.84 hits per line

AyuntamientoMadrid / consul / 8302 / 1
54%
master: 51%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8302.1 (2.3.2, KNAPSACK_PRO_CI_NODE_INDEX=0)

AyuntamientoMadrid / consul / 8302 / 1 54% master: 51%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8302.1 (2.3.2, KNAPSACK_PRO_CI_NODE_INDEX=0)

AyuntamientoMadrid / consul / 8302 / 1
54%
master: 51%

README BADGES
x