8302
54%
master: 51%

Ran 22 Jan 2018 11:49PM UTC

Jobs 2

Files 405

Run time 10min

Badge

Embed ▾

pending completion

Build # 8302

Build Type

push

travis-ci

Committed by

bertocq

Commit Message

Return 404 accesing community without communitable

Why:

Somehow we're seeing communities without proposals at production. We
must find why and fix it, but first we need to throw a 404 at the user
instead of a 500 internal server error

How:

First catching the scenario of non-existent communitable at the
controller and raising a 404 error. Secondly preventing the author_id
access over a possibly nil object, this is a smell but it can't be
easily fixed right now... we need to correctly implement a relation
between Community and communitable and avoid the multiple occurences of
`community.from_proposal?` in the codebase that makes it impossible to
extend to a fourth communitable model.

Run Details

8680 of 10356 relevant lines covered (83.82%)

444.15 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	8302.1 (2.3.2, KNAPSACK_PRO_CI_NODE_INDEX=0)	22 Jan 2018 11:49PM UTC	0	77.1	Travis Job 8302.1
2	8302.2 (2.3.2, KNAPSACK_PRO_CI_NODE_INDEX=1)	22 Jan 2018 11:59PM UTC	0	76.04	Travis Job 8302.2

Source Files on build 8302

Detailed source file information is not available for this build.

AyuntamientoMadrid / consul / 8302
54%
master: 51%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8302

AyuntamientoMadrid / consul / 8302 54% master: 51%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8302

AyuntamientoMadrid / consul / 8302
54%
master: 51%

README BADGES
x