7
86%
master: 86%

Ran 08 Jan 2018 06:37PM UTC

Files 289

Run time 11s

Badge

Embed ▾

Committed 08 Jan 2018 03:13PM UTC coverage: 19.423% (-0.004%) from 19.427%

Job # PRESET=pgsql_mnesia DB=pgsql REL_CONFIG=with-pgsql

Build Type

push

travis-ci

Committed by

fenek

Commit Message

Use Escalus with new story_with_client_list/3 and removed apply_w_arity_check magic (#1625)

* Test Escalus story-with-clients-as-list branch

* Test Escalus PR#162 (https://github.com/esl/escalus/pull/162)

* Fail in password_can_be_changed which gave false positives

Due to:

- no bob_altpass in Config's escalus_users
- escalus_story:apply_w_arity_check/2 logic:

	apply_w_arity_check(Fun, Args) when is_function(Fun, 1) ->
		case length(Args) of
			1 -> apply(Fun, Args);  %% Fun expects one logged-in user
			_ -> apply(Fun, [Args]) %% Fun expects list of users
		end;
	apply_w_arity_check(Fun, Args) when is_function(Fun) ->
		apply(Fun, Args).

`escalus_story:clients_from_resource_counts/2` did not expand `bob_altpass` to a client spec.
An empty list was returned instead.
Length of an empty list is 0, which made control flow through the _Fun expects list of users_
clause above, which in turn lead to `StoryFun` being passed a parameter for _Bob,
but the value of this parameter was actually an empty list,
not a successfully connected client.

This change makes this problem obvious by failing with a function_clause error.

* Fix and harden rest_SUITE:password_can_be_changed/1 test

* Use fixed Escalus

Run Details

5477 of 28198 relevant lines covered (19.42%)

101.87 hits per line

esl / MongooseIM / 3904 / 7
86%
master: 86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3904.7 (PRESET=pgsql_mnesia DB=pgsql REL_CONFIG=with-pgsql)

esl / MongooseIM / 3904 / 7 86% master: 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3904.7 (PRESET=pgsql_mnesia DB=pgsql REL_CONFIG=with-pgsql)

esl / MongooseIM / 3904 / 7
86%
master: 86%

README BADGES
x