3904
86%

Ran 08 Jan 2018 03:40PM UTC

Jobs 7

Files 289

Run time 310min

Badge

Embed ▾

pending completion

Build # 3904

Build Type

push

travis-ci

Committed by

fenek

Commit Message

Use Escalus with new story_with_client_list/3 and removed apply_w_arity_check magic (#1625)

* Test Escalus story-with-clients-as-list branch

* Test Escalus PR#162 (https://github.com/esl/escalus/pull/162)

* Fail in password_can_be_changed which gave false positives

Due to:

- no bob_altpass in Config's escalus_users
- escalus_story:apply_w_arity_check/2 logic:

	apply_w_arity_check(Fun, Args) when is_function(Fun, 1) ->
		case length(Args) of
			1 -> apply(Fun, Args);  %% Fun expects one logged-in user
			_ -> apply(Fun, [Args]) %% Fun expects list of users
		end;
	apply_w_arity_check(Fun, Args) when is_function(Fun) ->
		apply(Fun, Args).

`escalus_story:clients_from_resource_counts/2` did not expand `bob_altpass` to a client spec.
An empty list was returned instead.
Length of an empty list is 0, which made control flow through the _Fun expects list of users_
clause above, which in turn lead to `StoryFun` being passed a parameter for _Bob,
but the value of this parameter was actually an empty list,
not a successfully connected client.

This change makes this problem obvious by failing with a function_clause error.

* Fix and harden rest_SUITE:password_can_be_changed/1 test

* Use fixed Escalus

Run Details

6251 of 29145 relevant lines covered (21.45%)

640.47 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	3904.1 (PRESET=internal_mnesia DB=mnesia REL_CONFIG=with-all TLS_DIST=yes)	08 Jan 2018 03:41PM UTC	19.0	Travis Job 3904.1
2	3904.2 (PRESET=mysql_redis DB=mysql REL_CONFIG="with-mysql with-redis")	08 Jan 2018 03:40PM UTC	19.29	Travis Job 3904.2
3	3904.3 (PRESET=odbc_pgsql_mnesia DB=pgsql REL_CONFIG=with-odbc)	08 Jan 2018 03:46PM UTC	19.43	Travis Job 3904.3
4	3904.4 (PRESET=ldap_mnesia DB=mnesia REL_CONFIG=with-none)	08 Jan 2018 03:43PM UTC	20.82	Travis Job 3904.4
5	3904.5 (PRESET=cassandra_mnesia DB=cassandra REL_CONFIG=with-cassandra CASSANDRA_VERSION=3.9)	08 Jan 2018 03:42PM UTC	19.33	Travis Job 3904.5
7	3904.7 (PRESET=pgsql_mnesia DB=pgsql REL_CONFIG=with-pgsql)	08 Jan 2018 06:37PM UTC	19.42	Travis Job 3904.7
8	3904.8 (PRESET=riak_mnesia DB=riak REL_CONFIG=with-riak)	08 Jan 2018 08:50PM UTC	19.31	Travis Job 3904.8

Source Files on build 3904

Detailed source file information is not available for this build.

esl / MongooseIM / 3904
86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3904

esl / MongooseIM / 3904 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3904

esl / MongooseIM / 3904
86%

README BADGES
x