jshint / jshint / 2750 / 1
100%
master: 100%

DEFAULT BRANCH: master
Ran
Files 13
Run time 0s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 98.721% (-0.03%) from 98.746%
2750.1

Pull #3232

travis-ci

web-flow 
<a href="https://github.com/jshint/jshint/commit/20aa00540">[[CHORE]] Correct bug in test harness

Today, when a test expects an error to occur on a line that is
incorrect, the harness reports the situation in those terms. For
example, for the following test:

    exports.foo = function (test) {
      TestRun(test)
        .addError(9999, 1, &quot;Expected an assignment or function call and instead saw an expression.&quot;)
        .test(&quot;0;&quot;);
      test.done();
    };

The test harness reports:

&gt;     Errors with wrong location:
&gt;       {Line 1, Char 1} Expected an assignment or function call and instead saw an expression. - Not in line(s) {Line 9999, Char 1}

The requirement for tests to specify the character column for every
error is a recent addition to the test harness [1]. It was introduced
with only partial support in the test harness. That flaw did not impact
the harness&#39;s ability to identify test failures, but it did produce
confusing output in the event of failure.

When an error was reported with a character column that differed from
what was expected, the harness would simply report that the error was
defined but not thrown and omit details about the error that was
actually produced. For example, for the following test:

    exports.foo = function (test) {
      TestRun(test)
        .addError(1, 9999, &quot;Expected an assignment or function call and instead saw an expression.&quot;)
        .test(&quot;0;&quot;);
      test.done();
    };

...the harness would report the following error:

&gt;       Errors defined, but not thrown by JSHint:
&gt;         {Line 1, Char 9999} Expected an assignment or function call and instead saw an expression.

This patch corrects the harness&#39;s behavior so it instead reports:

&gt;       Errors with wrong location:
&gt;         {Line 1, Char 1} Expected an assignment or function call and instead saw an expression. - Not in line(s) {Line 1, Char 9999}

[1] </a><a class="double-link" href="https://github.com/jshint/jshint/commit/e0d575f28">e0d575f28</a>
Pull Request #3232: [[CHORE]] Correct bug in test harness

4014 of 4066 relevant lines covered (98.72%)

3584.21 hits per line

Source Files on job 2750.1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line