• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

jshint / jshint / 2750
100%

Build:
DEFAULT BRANCH: master
Ran 02 Jan 2018 03:38AM UTC
Jobs 4
Files 13
Run time 1353min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2750

Pull #3232

travis-ci

web-flow
<a href="https://github.com/jshint/jshint/commit/20aa00540">[[CHORE]] Correct bug in test harness

Today, when a test expects an error to occur on a line that is
incorrect, the harness reports the situation in those terms. For
example, for the following test:

    exports.foo = function (test) {
      TestRun(test)
        .addError(9999, 1, &quot;Expected an assignment or function call and instead saw an expression.&quot;)
        .test(&quot;0;&quot;);
      test.done();
    };

The test harness reports:

&gt;     Errors with wrong location:
&gt;       {Line 1, Char 1} Expected an assignment or function call and instead saw an expression. - Not in line(s) {Line 9999, Char 1}

The requirement for tests to specify the character column for every
error is a recent addition to the test harness [1]. It was introduced
with only partial support in the test harness. That flaw did not impact
the harness&#39;s ability to identify test failures, but it did produce
confusing output in the event of failure.

When an error was reported with a character column that differed from
what was expected, the harness would simply report that the error was
defined but not thrown and omit details about the error that was
actually produced. For example, for the following test:

    exports.foo = function (test) {
      TestRun(test)
        .addError(1, 9999, &quot;Expected an assignment or function call and instead saw an expression.&quot;)
        .test(&quot;0;&quot;);
      test.done();
    };

...the harness would report the following error:

&gt;       Errors defined, but not thrown by JSHint:
&gt;         {Line 1, Char 9999} Expected an assignment or function call and instead saw an expression.

This patch corrects the harness&#39;s behavior so it instead reports:

&gt;       Errors with wrong location:
&gt;         {Line 1, Char 1} Expected an assignment or function call and instead saw an expression. - Not in line(s) {Line 1, Char 9999}

[1] </a><a class="double-link" href="https://github.com/jshint/jshint/commit/e0d575f28">e0d575f28</a>
Pull Request #3232: [[CHORE]] Correct bug in test harness

4015 of 4066 relevant lines covered (98.75%)

14336.86 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2750.1 02 Jan 2018 04:03AM UTC 0
98.72
Travis Job 2750.1
2 2750.2 02 Jan 2018 03:38AM UTC 0
98.75
Travis Job 2750.2
3 2750.3 03 Jan 2018 02:11AM UTC 0
98.75
Travis Job 2750.3
4 2750.4 02 Jan 2018 03:57AM UTC 0
98.75
Travis Job 2750.4
Source Files on build 2750
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #2750
  • Pull Request #3232
  • PR Base - master (#2748)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc