50
86%
master: 86%

Ran 28 Oct 2014 01:30AM UTC

Files 1

Run time 2s

Badge

Embed ▾

Committed 27 Oct 2014 11:06PM UTC coverage: 94.62% (-0.07%) from 94.688%

Job # TOXENV=3.4,coveralls

Build Type

push

travis-ci

Committed by

ionelmc

Commit Message

Cleanup _get_original

The previous code had few issues:

- We try to import possibly non-exiting modules on each call, which is
  expensive, looking up the the module in the entire import path. This
  is also pointless since the module is not expected to appear after we
  found that it was not available.

- Do pointless lookups, becuase older lookups overwrite previous
  lookups. For example, if gevent is available, we would lookup twice,
  overwriting the pure Python lookup with gevent lookup. If both gevent
  and eventlet are available, we would do 3 lookups and return the
  eventlet lookup.

- Check for SynatxError on import looks wrong. I could not find the
  code that raise this in the gevent and evetlet.

- _get_original interface was strage, accepting a string, instead of
  the expected module and name arguemtns, as used by
  gevent.monkey.get_original.

Now we use simpler and more efficient solution:

- We try to import eventlet or gevent only once
- We define _get_original either using eventlet, gevent or our
  implementaion.
- We do only single lookup per call
- _get_original accpets module and name arguments

Run Details

299 of 316 relevant lines covered (94.62%)

0.95 hits per line

ionelmc / python-manhole / 268 / 50
86%
master: 86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 268.50 (TOXENV=3.4,coveralls)

ionelmc / python-manhole / 268 / 50 86% master: 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 268.50 (TOXENV=3.4,coveralls)

ionelmc / python-manhole / 268 / 50
86%
master: 86%

README BADGES
x