268
86%

Ran 28 Oct 2014 12:43AM UTC

Jobs 28

Files 1

Run time 53min

Badge

Embed ▾

pending completion

Build # 268

Build Type

push

travis-ci

Committed by

ionelmc

Commit Message

Cleanup _get_original

The previous code had few issues:

- We try to import possibly non-exiting modules on each call, which is
  expensive, looking up the the module in the entire import path. This
  is also pointless since the module is not expected to appear after we
  found that it was not available.

- Do pointless lookups, becuase older lookups overwrite previous
  lookups. For example, if gevent is available, we would lookup twice,
  overwriting the pure Python lookup with gevent lookup. If both gevent
  and eventlet are available, we would do 3 lookups and return the
  eventlet lookup.

- Check for SynatxError on import looks wrong. I could not find the
  code that raise this in the gevent and evetlet.

- _get_original interface was strage, accepting a string, instead of
  the expected module and name arguemtns, as used by
  gevent.monkey.get_original.

Now we use simpler and more efficient solution:

- We try to import eventlet or gevent only once
- We define _get_original either using eventlet, gevent or our
  implementaion.
- We do only single lookup per call
- _get_original accpets module and name arguments

Run Details

306 of 316 relevant lines covered (96.84%)

25.29 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	268.2 (TOXENV=2.6,coveralls)	28 Oct 2014 12:43AM UTC	93.99	Travis Job 268.2
3	268.3 (TOXENV=2.6-eventlet,coveralls)	28 Oct 2014 12:44AM UTC	82.59	Travis Job 268.3
6	268.6 (TOXENV=2.6-eventlet-patchthread,coveralls)	28 Oct 2014 12:46AM UTC	82.59	Travis Job 268.6
7	268.7 (TOXENV=2.6-gevent,coveralls)	28 Oct 2014 12:49AM UTC	93.04	Travis Job 268.7
10	268.10 (TOXENV=2.6-gevent-patchthread,coveralls)	28 Oct 2014 12:53AM UTC	93.04	Travis Job 268.10
12	268.12 (TOXENV=2.6-signalfd,coveralls)	28 Oct 2014 12:53AM UTC	93.67	Travis Job 268.12
13	268.13 (TOXENV=2.6-signalfd-eventlet,coveralls)	28 Oct 2014 12:54AM UTC	81.96	Travis Job 268.13
16	268.16 (TOXENV=2.6-signalfd-eventlet-patchthread,coveralls)	28 Oct 2014 12:58AM UTC	81.96	Travis Job 268.16
17	268.17 (TOXENV=2.6-signalfd-gevent,coveralls)	28 Oct 2014 01:01AM UTC	92.72	Travis Job 268.17
20	268.20 (TOXENV=2.6-signalfd-gevent-patchthread,coveralls)	28 Oct 2014 01:03AM UTC	92.72	Travis Job 268.20
22	268.22 (TOXENV=2.7,coveralls)	28 Oct 2014 01:03AM UTC	93.99	Travis Job 268.22
23	268.23 (TOXENV=2.7-eventlet,coveralls)	28 Oct 2014 01:06AM UTC	82.59	Travis Job 268.23
26	268.26 (TOXENV=2.7-eventlet-patchthread,coveralls)	28 Oct 2014 01:07AM UTC	82.59	Travis Job 268.26
27	268.27 (TOXENV=2.7-gevent,coveralls)	28 Oct 2014 01:08AM UTC	93.04	Travis Job 268.27
30	268.30 (TOXENV=2.7-gevent-patchthread,coveralls)	28 Oct 2014 01:13AM UTC	93.04	Travis Job 268.30
32	268.32 (TOXENV=2.7-signalfd,coveralls)	28 Oct 2014 01:13AM UTC	93.67	Travis Job 268.32
33	268.33 (TOXENV=2.7-signalfd-eventlet,coveralls)	28 Oct 2014 01:16AM UTC	81.96	Travis Job 268.33
36	268.36 (TOXENV=2.7-signalfd-eventlet-patchthread,coveralls)	28 Oct 2014 01:19AM UTC	81.96	Travis Job 268.36
37	268.37 (TOXENV=2.7-signalfd-gevent,coveralls)	28 Oct 2014 01:19AM UTC	92.72	Travis Job 268.37
40	268.40 (TOXENV=2.7-signalfd-gevent-patchthread,coveralls)	28 Oct 2014 01:22AM UTC	92.72	Travis Job 268.40
42	268.42 (TOXENV=3.2,coveralls)	28 Oct 2014 01:23AM UTC	95.25	Travis Job 268.42
44	268.44 (TOXENV=3.2-signalfd,coveralls)	28 Oct 2014 01:25AM UTC	94.94	Travis Job 268.44
46	268.46 (TOXENV=3.3,coveralls)	28 Oct 2014 01:28AM UTC	94.62	Travis Job 268.46
48	268.48 (TOXENV=3.3-signalfd,coveralls)	28 Oct 2014 01:30AM UTC	94.3	Travis Job 268.48
50	268.50 (TOXENV=3.4,coveralls)	28 Oct 2014 01:30AM UTC	94.62	Travis Job 268.50
52	268.52 (TOXENV=3.4-signalfd,coveralls)	28 Oct 2014 01:32AM UTC	94.3	Travis Job 268.52
54	268.54 (TOXENV=pypy,coveralls)	28 Oct 2014 01:35AM UTC	92.41	Travis Job 268.54
56	268.56 (TOXENV=pypy-signalfd,coveralls)	28 Oct 2014 01:37AM UTC	92.09	Travis Job 268.56

Source Files on build 268

Detailed source file information is not available for this build.

ionelmc / python-manhole / 268
86%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 268

ionelmc / python-manhole / 268 86%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 268

ionelmc / python-manhole / 268
86%

README BADGES
x