6
0%
master: 0%

Ran 12 Dec 2017 12:31PM UTC

Files 177

Run time 5s

Badge

Embed ▾

Committed 12 Dec 2017 12:18PM UTC coverage: 73.758% (+0.1%) from 73.609%

Job # TOX_ENV=py34-backend_postgres

Build Type

push

travis-ci

Committed by Bolke de Bruin

Commit Message

[AIRFLOW-1885] Fix IndexError in ready_prefix_on_cmdline

If while trying to obtain a list of ready gunicorn
workers, one of them
becomes a zombie, psutil.cmdline returns [] (see
here:
https://github.com/giampaolo/psutil/blob/release-4
.2.0/psutil/_pslinux.py#L1007)

Boom:

    Traceback (most recent call last):
      File "/usr/local/bin/airflow", line 28, in
<module>
        args.func(args)
      File "/usr/local/lib/python3.5/dist-
packages/airflow/bin/cli.py", line 803, in
webserver
        restart_workers(gunicorn_master_proc, num_workers)
      File "/usr/local/lib/python3.5/dist-
packages/airflow/bin/cli.py", line 687, in
restart_workers
        num_ready_workers_running = get_num_ready_workers_
running(gunicorn_master_proc)
      File "/usr/local/lib/python3.5/dist-
packages/airflow/bin/cli.py", line 663, in
get_num_ready_workers_running
        proc for proc in workers
      File "/usr/local/lib/python3.5/dist-
packages/airflow/bin/cli.py", line 664, in
<listcomp>
        if settings.GUNICORN_WORKER_READY_PREFIX in
proc.cmdline()[0]
    IndexError: list index out of range

So ensure a cmdline is actually returned before
doing the cmdline prefix
check in ready_prefix_on_cmdline.

Also:

 * Treat psutil.NoSuchProcess error as non ready
worker
 * Add in tests for get_num_ready_workers_running

Closes #2844 from j16r/bugfix/poll_zombie_process

Run Details

8983 of 12179 relevant lines covered (73.76%)

0.74 hits per line

airbnb / airflow / 8937 / 6
0%
master: 0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8937.6 (TOX_ENV=py34-backend_postgres)

airbnb / airflow / 8937 / 6 0% master: 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 8937.6 (TOX_ENV=py34-backend_postgres)

airbnb / airflow / 8937 / 6
0%
master: 0%

README BADGES
x