8937
0%

Ran 12 Dec 2017 12:18PM UTC

Jobs 6

Files 177

Run time 12min

Badge

Embed ▾

pending completion

Build # 8937

Build Type

push

travis-ci

Committed by Bolke de Bruin

Commit Message

[AIRFLOW-1885] Fix IndexError in ready_prefix_on_cmdline

If while trying to obtain a list of ready gunicorn
workers, one of them
becomes a zombie, psutil.cmdline returns [] (see
here:
https://github.com/giampaolo/psutil/blob/release-4
.2.0/psutil/_pslinux.py#L1007)

Boom:

    Traceback (most recent call last):
      File "/usr/local/bin/airflow", line 28, in
<module>
        args.func(args)
      File "/usr/local/lib/python3.5/dist-
packages/airflow/bin/cli.py", line 803, in
webserver
        restart_workers(gunicorn_master_proc, num_workers)
      File "/usr/local/lib/python3.5/dist-
packages/airflow/bin/cli.py", line 687, in
restart_workers
        num_ready_workers_running = get_num_ready_workers_
running(gunicorn_master_proc)
      File "/usr/local/lib/python3.5/dist-
packages/airflow/bin/cli.py", line 663, in
get_num_ready_workers_running
        proc for proc in workers
      File "/usr/local/lib/python3.5/dist-
packages/airflow/bin/cli.py", line 664, in
<listcomp>
        if settings.GUNICORN_WORKER_READY_PREFIX in
proc.cmdline()[0]
    IndexError: list index out of range

So ensure a cmdline is actually returned before
doing the cmdline prefix
check in ready_prefix_on_cmdline.

Also:

 * Treat psutil.NoSuchProcess error as non ready
worker
 * Add in tests for get_num_ready_workers_running

Closes #2844 from j16r/bugfix/poll_zombie_process

Run Details

9029 of 12179 relevant lines covered (74.14%)

4.42 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	8937.1 (TOX_ENV=py27-backend_mysql)	12 Dec 2017 12:23PM UTC	73.73	Travis Job 8937.1
2	8937.2 (TOX_ENV=py27-backend_sqlite)	12 Dec 2017 12:18PM UTC	73.69	Travis Job 8937.2
3	8937.3 (TOX_ENV=py27-backend_postgres)	12 Dec 2017 12:28PM UTC	73.74	Travis Job 8937.3
4	8937.4 (TOX_ENV=py34-backend_mysql)	12 Dec 2017 12:27PM UTC	73.65	Travis Job 8937.4
5	8937.5 (TOX_ENV=py34-backend_sqlite)	12 Dec 2017 12:22PM UTC	73.59	Travis Job 8937.5
6	8937.6 (TOX_ENV=py34-backend_postgres)	12 Dec 2017 12:31PM UTC	73.76	Travis Job 8937.6

Source Files on build 8937

Detailed source file information is not available for this build.

airbnb / airflow / 8937
0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8937

airbnb / airflow / 8937 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8937

airbnb / airflow / 8937
0%

README BADGES
x